add a fixer method to the no-deprecated-custom-properties ESlint rule
#2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d15721 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 214 214
Lines 12557 12557
Branches 1684 1684
=======================================
Hits 10961 10961
Misses 1543 1543
Partials 53 53 |
sirineJ
force-pushed
the
fix/add-fixer-to-no-deprecated-custom-properties-eslint-rule
branch
from
0d2c89e
to
d56dd32
Compare
|
Size Change: 0 B Total Size: 639 kB ℹ️ View Unchanged
|
connor-baer
reviewed
Oct 31, 2024
.changeset/tricky-cups-wave.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@sumup-oss/eslint-plugin-circuit-ui": major | |||
There was a problem hiding this comment.
This is an additive, non-breaking change.
Suggested change
| "@sumup-oss/eslint-plugin-circuit-ui": major | |
| "@sumup-oss/eslint-plugin-circuit-ui": minor |
sirineJ
force-pushed
the
fix/add-fixer-to-no-deprecated-custom-properties-eslint-rule
branch
from
d56dd32
to
3d15721
Compare
sirineJ
deleted the
fix/add-fixer-to-no-deprecated-custom-properties-eslint-rule
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-847
Purpose
After the typography revamp for v9, a new ESlint rule
circuit-ui/no-deprecated-custom-propertieswas added to flag deprecated custom properties. In order to make the migration to CUI v9 easier, a fixer function would help migrate deprecated custom props automatically.Approach and changes
fixable: 'code'to rule metaDefinition of done