This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Allow reproducible builds independent of output destination #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the project I'm working on we're trying to get reproducible builds with a project that uses ember.js. We're using
ember-cli-webfont(which usesbroccoli-webfont).The ember-cli build system uses temporary directories to store the addons output. Furthermore - it uses absolute paths. This means that two builds can have very different
destoptions (e.g./home/user1/project/tmp/something-RLHbiENl.tmpand/home/user2/work/project/tmp/something-QMgOe8NX.tmp). Sincedestis part of options it will be used when a hash is created in renderCss.js.The proposal here is to ignore the
dest,cssDest,htmlDest(all options that are only relative to the output) when calculating the hash. This way otherwise identical options can generate identical output.