feat: events #136
Merged
feat: events #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimurayu45z |
kimurayu45z
commented
Nov 18, 2024
x/tokenconverter/keeper/convert.go
Outdated
| @@ -57,5 +57,12 @@ func (k Keeper) BurnAndMint(ctx context.Context, amount math.Int, address sdk.Ac | |||
| return err | |||
| } | |||
|
|
|||
| if err := sdk.UnwrapSDKContext(ctx).EventManager().EmitTypedEvent(&types.EventBurnAndMint{ | |||
There was a problem hiding this comment.
EventConvertでいいかも
kimurayu45z
commented
Nov 18, 2024
x/liquiditypool/keeper/position.go
Outdated
| @@ -133,6 +142,10 @@ func (k Keeper) RemovePosition(ctx context.Context, id uint64) { | |||
| storeAdapter := runtime.KVStoreAdapter(k.storeService.OpenKVStore(ctx)) | |||
| store := prefix.NewStore(storeAdapter, types.KeyPrefix(types.PositionKey)) | |||
| store.Delete(GetPositionIDBytes(id)) | |||
|
|
|||
| _ = sdk.UnwrapSDKContext(ctx).EventManager().EmitTypedEvent(&types.EventRemovePosition{ | |||
There was a problem hiding this comment.
DB操作に関するigniteに自動生成された関数はイベントなしでいいわ
There was a problem hiding this comment.
Txに絡めてイベント発火したいってこと？細かく出すならDBで出した方がいいと思うが
kimurayu45z
commented
Nov 20, 2024
x/liquiditypool/keeper/position.go
Outdated
| @@ -45,6 +45,14 @@ func (k Keeper) AppendPosition(ctx context.Context, position types.Position) uin | |||
| // Set the ID of the appended value | |||
| position.Id = count | |||
| k.SetPosition(ctx, position) | |||
| _ = sdk.UnwrapSDKContext(ctx).EventManager().EmitTypedEvent(&types.EventSetPosition{ | |||
There was a problem hiding this comment.
AppendXXXもIgnite自動生成のdb関数だからイベントなしで
kimurayu45z
commented
Nov 20, 2024
| uint64 pool_id = 1; | ||
| } | ||
|
|
||
| message EventSetPosition { |
There was a problem hiding this comment.
Setは内部処理の単語なのでCreate, Updateという単語を使いたい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #131
Overview