fix: bug decrease liquidity #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurayu45z
reviewed
Nov 23, 2024
| @@ -226,8 +214,15 @@ func (k Keeper) DecreaseLiquidity(ctx sdk.Context, sender sdk.AccAddress, positi | |||
| return math.Int{}, math.Int{}, errorsmod.Wrapf(types.ErrPoolNotFound, "pool id: %d", position.PoolId) | |||
| } | |||
|
|
|||
| liquiditDelta := liquidity.Neg() | |||
| amountBase, amountQuote, lowerTickEmpty, upperTickEmpty, err := k.UpdatePosition(ctx, position.PoolId, sender, position.LowerTick, position.UpperTick, liquiditDelta, positionId) | |||
| if liquidity.Equal(position.Liquidity) { | |||
There was a problem hiding this comment.
Question:
Is if liquidity.Equal(position.Liquidity) { really needed?
I am thinking of a possibility that we should collect fees anytime
There was a problem hiding this comment.
Need to dig the relation with k.SetAccumulatorPositionFeeAccumulator
There was a problem hiding this comment.
I don't see a problem since this function is only called for DecreaseLiquidity and IncreaseLiquidity.
simple and good.
There was a problem hiding this comment.
I've already merged #141, and to avoid confusion, it's better to change the spec from v0.3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed a problem in the DecreaseLiquidity and IncreaseLiquidity process that caused incorrect settlements.
Rewards are now correctly earned with IncreaseLiquidity and DecreaseLiquidity.
Details
L149-159
Remove unnecessary SetPosition. No need to update DB here.
R217-225
Changed so that rewards are claimed before positions are deleted. Fixed typo
liquiditDeltaL247-L264
The location of the rewards claim was changed before the position was changed (R217-225). Other logic has been integrated into the
UpdatePositionfunction to avoid wasteful processing.R356-R374 & R382-R400
The deleted L247-L264 process has been integrated here. To avoid both deleting and updating positions.