Fix: Synchronize position deletion in PositionsByPoolId

[pri-3x]

Overview

fix #143
This PR addresses an issue where the Delete method did not synchronize the deleted position in the PositionsByPoolId store.

Changes Made:

• Updated the RemovePosition method in the store_position.go file to ensure that when a position is deleted from the main store, it is also removed from the corresponding PositionsByPoolId store.
• Added logic to retrieve the PoolId of the deleted position and delete the position from the pool-specific store.

Impact:

This change ensures that the state of the positions is consistent across all relevant stores, preventing potential issues with data integrity when querying positions by pool ID after deletions.

[kimurayu45z]

If this function is executed after store.Delete(GetPositionIDBytes(id)), it would always return [Empty], false.

Shouldn't it be like below?

func (k Keeper) RemovePosition(ctx context.Context, id uint64) {
	storeAdapter := runtime.KVStoreAdapter(k.storeService.OpenKVStore(ctx))
	store := prefix.NewStore(storeAdapter, types.KeyPrefix(types.PositionKey))
	store.Delete(GetPositionIDBytes(id))

	k.RemovePositionsByPool(ctx, id)
	k.RemovePositionsByAddress(ctx, id)
}

// Remove PositionBy Pool
func RemovePositionsByPool(...) {
  store = prefix.NewStore(storeAdapter, types.PositionByPoolPrefix(poolId))
  iterator := storetypes.KVStorePrefixIterator(store, []byte{})
  defer iterator.Close()

  for ; iterator.Valid(); iterator.Next() {
    id := sdk.BigEndianToUint64(iterator.Value())
    store.Delete(iterator.Value())
  }
}
// Remove PositionsByAddress
func RemovePositionsByAddress(...) {
  // Do similar things
}

[kimurayu45z]

Thank you for submitting a Pull Request, I appreciate it!
Please check the review comment.

[pri-3x]

Thank you for submitting a Pull Request, I appreciate it! Please check the review comment.

Thanks for the feedback, can you review the changes again?

[kimurayu45z]

Thank you for revision!
I will merge this PR, and I will fix slight remaining parts.

[pri-3x]

@kimurayu45z Thankyou :)
Would you be willing to share your email or preferred professional contact method please?

[kimurayu45z]

Contact me in Discord of Sunrise server.
https://discord.com/invite/sunrise