-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SignInWithIdToken not returning updated session #89
Comments
Hm interesting, I'll look into it! |
Can you check with v4.3.0 as to whether this issue has been resolved? |
Will do and let you know today
…On Fri, 5 Apr, 2024, 8:56 am Joseph Schultz, ***@***.***> wrote:
Can you check with v4.3.0 as to whether this issue has been resolved?
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG2A55OZ4OXWBLQVYCM6YTY3YKU7AVCNFSM6AAAAABFUYGYE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYG43TANRRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes its working now and I am getting the updated session, thanks a lot. Right now, I have made a java(aar) plugin for chrome tab (for android) to use it with Unity in order to signin to facebook via PKCE and deep linking, its working. Then i had to call fb graph api to get my access_token so that I can get user extra data like friends and all, it also works. I can see that you added facebook and azure support in signinwithidtoken, but gain, it has to be used with PKCE flow for facebook. I hope that in future, supabase can support native signin for facebook and other social media. Thanks a lot for your quick resolution. |
@kaushalkumar86 thanks for your patience on getting all that working! I refactored the Our client will not be implementing platform dependent native sign-on - we are providing support for the developer to tie in native sign-in with their supabase instance. There are unfortunately just too many platforms with too many varying/exclusive requirements to include it within the client implementation itself. Outside of the browser, this will be through PKCE flows. However, @wiverson has done a lot of the legwork in showing how you can do PKCE flows here. It's worth checking out! Hope that helps, |
Thanks for the update,
I have contacted @wiverson last year, suggested him proguard rules and
continous networkstatus check for games which need continuousconnection to
internet.
With the help of his video, I was able to successfully switch to supabase
and implement native Google signin with sdk.
Already using PKCE flow with deeplinking to signin to supabase.
Your docs are self explanatory and very helpful.
…On Fri, 5 Apr, 2024, 5:51 pm Joseph Schultz, ***@***.***> wrote:
@kaushalkumar86 <https://github.com/kaushalkumar86> thanks for your
patience on getting all that working! I refactored the SignInWithIdToken
method, it was adding an access_token key to the body of the request even
if the access_token was null. This hotfix is available in v4.3.1.
Our client will not be implementing *platform dependent* native sign-on -
we are providing support for the *developer* to tie in native sign-in
with their supabase instance. There are unfortunately just too many
platforms with too many varying/exclusive requirements to include it within
the client implementation itself. Outside of the browser, this will be
through PKCE flows.
However, @wiverson <https://github.com/wiverson> has done a lot of the
legwork in showing how you can do PKCE flows here
<https://github.com/supabase-community/supabase-csharp/wiki/Authorization-with-Gotrue#3rd-party-oauth>.
It's worth checking out!
Hope that helps,
Joseph
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG2A5Y2SG2CMRMSNK7NBWDY32JMFAVCNFSM6AAAAABFUYGYE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGY2TOMBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
when called
Session session = await supabase.Auth.SignInWithIdToken(Constants.Provider.Google, task.Result.IdToken);
the resultant session does not contain vales for Google provider, that is, the session value itself is not null but session.User.Identities does not contain anything, its count values is 0.
Have to use
supabase.Auth.LoadSession();
Session session = await supabase.Auth.RetrieveSessionAsync();
after signin to get proper updated session details with User.Identities to check for provider and its data.
The text was updated successfully, but these errors were encountered: