-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces, bug fixes, additional error reason detection #60
Merged
acupofjose
merged 14 commits into
supabase-community:master
from
wiverson:add_interface
May 11, 2023
Merged
Add interfaces, bug fixes, additional error reason detection #60
acupofjose
merged 14 commits into
supabase-community:master
from
wiverson:add_interface
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, more bug fixes included. |
wiverson
changed the title
Add interfaces
Add interfaces, bug fixes, additional error reason detection
May 11, 2023
acupofjose
approved these changes
May 11, 2023
Available in 4.0.1 - Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a few of the new methods to the interfaces so they are accessible via the parent supabase-csharp.
Also adds several additional Reasons to help with failures.
What is the current behavior?
A few new methods were only available via the concrete classes, not the interfaces. This means they are not available when using the main supabase client to access (e.g. _supabase.Auth).
What is the new behavior?
Added the missing methods to the interfaces. Also updated the test cases to use the interfaces instead of the concrete implementations to help reduce this error in the future.
Additional context
Builds on the changes from #57