Refresh Thread bug fixes, add offline support for stateful end user client. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved refresh logic to another class. Now the thread gets turned on/off automatically per auth state changes. Commit looks noisy than should because of format tweaks, sorry. :/
All of the calls to check for expiration in the current implementation were checking to see if the session had expired.
|
Also added support for offline mode. This only affects the stateful client non-admin JWT methods (i.e. the stateful end user client). This fixes a problem I was having where the stateful client would simply wipe out the user session if the network wasn't available. I need a user to be able to interact with the app in a mobile environment in which offline/online is a bit less reliable. |
wiverson
changed the title
|
Ok, all set on my end to merge / review /etc. :) |
acupofjose
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes some bugs and improves the stability for the background token refresh thread. Simplifies logic for refresh thread. Adds option for maximum wait time. Adds a few test cases.
No meaningful API changes (does add a distinction between invalid session and expired token).