Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Shutdown. Moved docs to interfaces. #67

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

wiverson
Copy link
Collaborator

What kind of change does this PR introduce?

Adds a Shutdown option to the auth state notification. This provides a mechanism to manually terminate the background refresh thread without logging out. This allows the client to be used cleanly when running in the Unity editor.

In addition, went ahead and moved the docs to the interfaces and inherit docs on the implementation - less copy and paste FTW.

What is the current behavior?

Only user visible / API change is the addition of the Shutdown auth state. It's possible that if client code is throwing an exception on an unexpected state change they might get an exception here. This is the kind of thing that IDEs like Rider are pretty good at catching in static code analysis FWIW.

Oh, and now the docs should be visible for IDEs when working with both the interfaces and the implementation code.

@acupofjose
Copy link
Contributor

@wiverson please see comments from review ^ not sure if it sent you a notification

@wiverson
Copy link
Collaborator Author

Nope, I'm not seeing any comments...? If you want to mod/tweak just go for it of course. :)

@wiverson
Copy link
Collaborator Author

FWIW this is all I see
image

@acupofjose
Copy link
Contributor

Turns out I have to submit it before the comment shows. Who knew? 😂

@acupofjose acupofjose merged commit f081660 into supabase-community:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants