Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for init command #303

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Add unit tests for init command #303

merged 3 commits into from
Jul 20, 2022

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 20, 2022

What kind of change does this PR introduce?

Unit tests with in-memory file system.

What is the current behavior?

Config tests writes out to local filesystem.

What is the new behavior?

  • Uses afero as the abstract file system (io/fs only supports read operations, read/write proposal is in progress)
  • Simplifies config tests to use afero
  • Adds unit test for init command

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from soedirgo July 20, 2022 06:21
internal/init/init.go Outdated Show resolved Hide resolved
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🔥

@soedirgo soedirgo merged commit 687d39b into main Jul 20, 2022
@soedirgo soedirgo deleted the init-test branch July 20, 2022 08:10
@github-actions
Copy link

🎉 This PR is included in version 0.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants