Adding Melos for monorepo management #681
Conversation
| # Override to local mono-repo path so devs can test this repo | ||
| # against changes that they're making to other mono-repo packages | ||
| attributed_text: | ||
| path: ../../attributed_text |
There was a problem hiding this comment.
Is there a reason that this one dependency is left under overrides, but all the others are listed above as regular deps?
There was a problem hiding this comment.
This dependency is transitive, the others are direct.
There was a problem hiding this comment.
Ok, can you adjust the comment to make that clear? The other dependencies are also "to local mono-repo path" so it's not obvious why this one is different. But if you explain that it's transitive then the reader should understand.
There was a problem hiding this comment.
Done, let me know if you want me to revise the new comments to be more verbose
|
My plan is to get this PR and the AttributedText PR merged after the next couple releases, because we're almost done with a couple deliverables. BTW, it looks like Windows tests are failing in CI |
Cool, I'll keep the branches up to date with
Well this is annoying. Turns out there was a bug introduced in Dart |
jmatth
force-pushed
the
melos
branch
2 times, most recently
from
78be9ed to
460817f
Compare
|
@matthew-carroll This is ready for another look if you're still interested in this change. #680 describes the reasoning and proposes an alternative if you don't want to add a dependency on an external tool. |
|
Yeah, I'd like to get this in, but can we start with the attribution range change? |
|
I'm going to close this because it's so out of date. We still want this. I'll probably refactor for Melos before the next major release. That will be a different PR. |
See #680 for details. Let me know if the update to the root readme should be moved or copied to any of the individual project readmes. I was on the fence about doing so but it seems potentially annoying to maintain setup instructions in each individual package as the repo grows. Maybe just add a line to each one saying to refer to the root readme to set up your development environment?
Closes #680.