Changed Text ui to expect references of std:string instead of a copy #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes aim to avoid generating two copies of the std::string when the classes' clients use the methods like setText: ```cpp // This way the function will receive the parameter by copy void setFont(std::string font); ``` ```cpp // Receives the string by reference without creating a new copy void setFont(const std::string &font); ```
|
I think for modern compilers it makes no difference. But always a good practice. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to avoid generating two copies of the std::string when the classes' clients use the methods like setText:
Let me know your thoughts, and I can replicate the same change throughout the project.