Travis/jest #122
Merged
Travis/jest #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
festinalente91
commented
Nov 17, 2016
festinalente91
commented
- fixing travis jest config bug
- Cannot find module 'ReactNativeDefaultInjection' from 'setup.js' jestjs/jest#1840
* added location service dialog box for Android * deleted map test due to having trouble on using jest
festinalente91
assigned fguy, festinalente91, ovekyc, ochanje210, yuda1124 and shberry16
|
we gotta solve this asap guys |
|
yes! I fixed! Adding babel plugin module resolver solved this problem. but now we are having node security failing which I just added. |
|
the one vulnerability issue we are having right now from negotiator module connected to react-native does not seem to be a big deal as mentioned from the issue above. |
|
shipping it anyway. lgtm |
|
@festinalente91 do not make branch from another branch.. |
ochanje210
pushed a commit
that referenced
this pull request
Nov 17, 2016
* Add image resize code * Travis/jest (#122) * added location service dialog box for Android (#115) * added location service dialog box for Android * deleted map test due to having trouble on using jest * warning fix (#116) * selecting on existing location highlights the button (#114) * Update README.md * update jest config * add babel plugin module resolver * add negotiator with latest version in order to avoid node security fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.