Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple testing library #275

Merged
merged 73 commits into from
Nov 11, 2024
Merged

feat: simple testing library #275

merged 73 commits into from
Nov 11, 2024

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Nov 7, 2024

Alternative to #32

This takes more of a lightweight approach where we provide a bare minimum api for testing rather than controlling the whole testing pipeline. This should allow for better flexibility as we're no longer tied to any particular testing framework.

Notes:

  • Had to rename the directory of the vitest addon as it was somehow interfering with vitest or tinypool during runtime, causing shit to randomly break
  • Storybook has been pinned to v8.3.x as v8.4.x flat out doesn't work. I haven't had a moment to fully investigate the issue yet.

TODO:

  • Snapshots?
  • look into using vitest workspaces
  • Should we continue to use degit to clone the vite templates? If so, should we pin it to a specific commit hash (see here)? Or should this be something we manage fully (perhaps as part of create)?

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: b6d91be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@275
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@275

commit: b6d91be

@AdrianGonz97 AdrianGonz97 merged commit 5941575 into main Nov 11, 2024
8 checks passed
@AdrianGonz97 AdrianGonz97 deleted the feat/simple-testing-lib branch November 11, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants