-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken link #284
Conversation
|
preview: https://svelte-dev-git-preview-cli-284-svelte.vercel.app/ this is an automated message |
@@ -2,7 +2,7 @@ | |||
title: sv migrate | |||
--- | |||
|
|||
`sv migrate` migrates Svelte(Kit) codebases. It delegates to the [`svelte-migrate`](https://github.com/sveltejs/kit/blob/main/packages/migrate) package. | |||
`sv migrate` migrates Svelte(Kit) codebases. It delegates to the [`svelte-migrate`](npmjs.com/package/svelte-migrate) package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`sv migrate` migrates Svelte(Kit) codebases. It delegates to the [`svelte-migrate`](npmjs.com/package/svelte-migrate) package. | |
`sv migrate` migrates Svelte(Kit) codebases. It delegates to the [`svelte-migrate`](https://www.npmjs.com/package/svelte-migrate) package. |
But also: Would it be more helpful to link to the location of the package in this repo, rather than to npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
But also: Would it be more helpful to link to the location of the package in this repo, rather than to npm?
I don't think so, which is why I changed it. Is there a reason you think that might be more helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it even worth to mention that in the docs? It's more of an internal thing for me at least. Also does not look like we have a similar sentence for check
in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of articles, blog posts, tweets, etc. mentioning the two, so I think it's helpful for users to know what the difference is between them and how they relate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. But I guess all the docs have been updated to refer to sv, so maybe the more important place to put this is the svelte-migrate readme
Co-authored-by: Conduitry <[email protected]>
closes #283