Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore path prompt if user provided path in create #292

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

manuel3108
Copy link
Member

Closes #291

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 424966d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@292
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@292

commit: 63182d9

@benmccann
Copy link
Member

I liked the name userProvidedPath better, so might revert the last commit 😆

@manuel3108
Copy link
Member Author

I was debating, that sounded too much as a string for me. I thought about adding an is or has, but that all sounded strange :)

@AdrianGonz97 AdrianGonz97 merged commit 4e6552b into main Nov 11, 2024
6 checks passed
@AdrianGonz97 AdrianGonz97 deleted the fix/ignore-path-prompt-if-provided branch November 11, 2024 20:53
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv create ignore when the path given is the current directory
3 participants