Revert "fix: build service workers in IIFE format" (#11400)

* Revert "fix: build service workers in IIFE format (#11129)" This reverts commit 5f052a3. * better fix * changeset * remove format --------- Co-authored-by: Rich Harris <[email protected]>
sveltejs · Dec 19, 2023 · 197e01f · 197e01f
1 parent f8e3d8b
commit 197e01f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/.changeset/green-cycles-shake.md b/.changeset/green-cycles-shake.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: prevent esbuild adding phantom exports to service worker
diff --git a/.changeset/tricky-meals-perform.md b/.changeset/tricky-meals-perform.md
diff --git a/packages/kit/src/exports/vite/build/build_service_worker.js b/packages/kit/src/exports/vite/build/build_service_worker.js
@@ -70,10 +70,8 @@ export async function build_service_worker(
 					'service-worker': service_worker_entry_file
 				},
 				output: {
-					// default 'es' format would be nicer
-					// iife is workaround for https://github.com/vitejs/vite/issues/15379
-					format: 'iife',
-					entryFileNames: '[name].js',
+					// .mjs so that esbuild doesn't incorrectly inject `export` https://github.com/vitejs/vite/issues/15379
+					entryFileNames: 'service-worker.mjs',
 					assetFileNames: `${kit.appDir}/immutable/assets/[name].[hash][extname]`,
 					inlineDynamicImports: true
 				}
@@ -95,4 +93,7 @@ export async function build_service_worker(
 			}
 		}
 	});
+
+	// rename .mjs to .js to avoid incorrect MIME types with ancient webservers
+	fs.renameSync(`${out}/client/service-worker.mjs`, `${out}/client/service-worker.js`);
 }