-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Google Cloud in adapter-auto #12015
feat: support Google Cloud in adapter-auto #12015
Conversation
🦋 Changeset detectedLatest commit: bc2bc17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ghostdevv - Thank you so much for the approval. This is my first PR to Svelte, so I wanted to see if there's anything else I need to do to merge this PR? No rush, I just want to make sure I haven't missed anything. (This was my first time using Changeset Bot, so I'm not sure I got everything right.) |
@LukeSchlangen there shouldn't be anything else needed from you at the moment. We'll want to get another approval on this and then hopefully should be good to merge or address feedback. |
Sounds great. Thanks so much for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the instructions on a fresh SvelteKit app and confirmed this works without additional configuration - all I did was manually install the Node adapter (which adapter-auto will handle after this PR). Thanks!
Requesting reviews from a couple other maintainers who have reviewed similar PRs in the past just to make sure no one has any objections, but I think this is good to merge. |
Thank you all so much! No rush on my end, but for transparency, I did test these commands and they don't work yet:
I still get the error: As long as that sounds right to you, I think we're in great shape! |
@LukeSchlangen It'll be released when #12042 is merged! |
Fantastic. That's very exciting. Thanks for all your help! |
Released |
Confirmed deployment working on Google Cloud Run! Thanks everyone! |
This Pull Request supports zero-config deployments to Google Cloud Run and resolves #11951
After this change is merged (assuming
npm
andgcloud
CLIs are installed), it should only require these three commands to create and deploy a SvelteKit application to Google Cloud Run:npm create svelte@latest sveltekit-app
cd sveltekit-app
gcloud run deploy --allow-unauthenticated
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits