Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove images from route-level config #12280

Merged
merged 6 commits into from
Jun 5, 2024
Merged

fix: remove images from route-level config #12280

merged 6 commits into from
Jun 5, 2024

Conversation

benmccann
Copy link
Member

The include in the tsconfig.json was causing the index file in adapter-vercel not to be type checked. I removed it to type check all files. I added images to the edge config to get it to pass. @dummdidumm could you verify if that's correct?

@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label May 30, 2024
@benmccann benmccann requested a review from dummdidumm May 30, 2024 21:01
Copy link

changeset-bot bot commented May 30, 2024

🦋 Changeset detected

Latest commit: ad7bc00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the title fix: add images to edge config types fix: remove images from route-level config Jun 5, 2024
@benmccann
Copy link
Member Author

Awesome. Thanks for the help in getting this over the finish line!

@Conduitry
Copy link
Member

stupid-lies-remain as a changeset filename feels like an omen on a PR where we are bending the rules of semver.

They remain.

@Rich-Harris Rich-Harris merged commit 7133648 into main Jun 5, 2024
12 of 13 checks passed
@Rich-Harris Rich-Harris deleted the vercel-types branch June 5, 2024 19:39
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants