Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include importer in illegal import error message #12820

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 16, 2024

closes #12550

Uses the resolveId hook to get the importer name before including it in the error message when loading the illegal import in the load hook.

However, I couldn't figure how to get this working for server only imports since those don't trigger the resolveId hook. (at least when I was running console logs to see if it did trigger it).


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: a7bb8ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

It seems a bit more future-proof to me to instead maintain a map/lookup in the resolveId hook - and then in the load hook, check whether we happen to know what was importing this forbidden module - rather than making this specific to $env/ prefixes in both places. I realize you said that this doesn't seem to be working currently for server-only imports, but doing this in a more general way makes it easier to add that eventually when we figure it out.

@eltigerchino
Copy link
Member Author

eltigerchino commented Oct 16, 2024

Thanks for the suggestion! I've replaced it with an import map.

@dummdidumm dummdidumm merged commit dcbe422 into main Oct 23, 2024
13 checks passed
@dummdidumm dummdidumm deleted the report-illegal-importer branch October 23, 2024 21:25
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
benmccann pushed a commit that referenced this pull request Oct 25, 2024
closes #12550

Uses the resolveId hook to get the importer name before including it in the error message when loading the illegal import in the load hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import $env/dynamic/private into client-side code should include context
3 participants