-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include importer in illegal import error message #12820
Conversation
🦋 Changeset detectedLatest commit: a7bb8ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It seems a bit more future-proof to me to instead maintain a map/lookup in the |
Thanks for the suggestion! I've replaced it with an import map. |
closes #12550 Uses the resolveId hook to get the importer name before including it in the error message when loading the illegal import in the load hook.
closes #12550
Uses the
resolveId
hook to get the importer name before including it in the error message when loading the illegal import in theload
hook.However, I couldn't figure how to get this working for server only imports since those don't trigger the
resolveId
hook. (at least when I was running console logs to see if it did trigger it).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits