-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added most common status codes to redirect() doc #13301
Conversation
🦋 Changeset detectedLatest commit: 2810e2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13301-svelte.vercel.app/ this is an automated message |
* * `307 Temporary Redirect`: redirect will keep the request method | ||
* * `308 Permanent Redirect`: redirect will keep the request method, SEO will be transferred to the new page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely confident that 307 doesn't have some SEO implications. I'd simplify it to remove that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the whole text could be squashed down to something like "Prefer 307 for temporary redirects and 308 for permanent redirects." |
Thanks for the review! I believe 303 is the best choice for post-action redirect, and that's what we can see in the docs too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency for http verbs
Hey! Small QOL improvement, I often google HTTP status codes to know which one I should use. I picked the three values that should cover 99% of use cases;
302 Found
is not in there because its behavior is disambiguated by 303 and 307.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits