-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: outdated endpoint in todo example app #1344
Conversation
Thank you. I'm in two minds about the global import type { Locals } from '$lib/types'; or something instead? |
(The flip side of course is that you might well prefer to make it global in your app. Tough one.) |
I was thinking the same, some of the considerations for making it global was (as mentioned) convenience and for an example on the possibility of adding global types/interfaces (since Then again, having it exported from |
Perhaps the best-of-both-worlds solution is to use |
I love it, that's genius. Done! |
Perfect, thank you! One last thing I forgot to mention before — could you run |
@Rich-Harris I've added a changeset. |
Fixes #1341
Also add global interface to be passed in
RequestHandler
and fix lint errors.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts