Use general purpose edge functions for vercel-adapter #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d34602 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
May 12, 2022
Rich-Harris
approved these changes
May 12, 2022
This will use general purpose edge functions instead of our Middleware infrastructure. This will support Cache-Control and also streamlines the routing.
Schniz
force-pushed
the
use-general-purpose-edge-functions
branch
from
cbf314a
to
9034391
Compare
Rich-Harris
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Edge deployment on Vercel is piggybacking Middleware.
This PR uses the new general purpose Edge Function deployment mechanism to deploy them.
This enables Cache-Control support, for instance, and a more streamlined configuration (no
middlewarePath, and usingdestinstead when rewriting).I also fixed a bug for the root
/__data.jsonfile when running insplit: truemode.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0