-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vercel): ESM support and Node.js 16 #4904
Conversation
🦋 Changeset detectedLatest commit: 419dc8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks — can we auto-detect the node version? The same version is used during build as in the deployment, so we should be able to get rid of the option altogether and Do The Right Thing based on |
@Rich-Harris Done! |
thank you! |
Fixes #4782
This PR adds support for ESM deployments to Vercel by adding a package.json with
{ "type": "module" }
(AWS post about this).It also allows the user to select which Node.js version they want to use (it can beIt also allows deploying to Node.js 16, which can be configure inside the Vercel Project's settings16.x
(default),14.x
or12.x
).Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0