Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve create-svelte types #517

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Improve create-svelte types #517

merged 3 commits into from
Mar 14, 2021

Conversation

GrygrFlzr
Copy link
Member

@GrygrFlzr GrygrFlzr commented Mar 14, 2021 •
edited
Loading

  • Re-added globals.d.ts to JS template
    • This should work even without TypeScript
  • Fixed globals.d.ts TSDoc notation
    • Previously comments were not showing up properly
  • Reference vite/client in globals.d.ts
    • Type support for Vite features like import.meta.glob or import.meta.globEager
  • Upped tsconfig target to es2018
    • This is our current target for svelte-kit build
  • Enable checkJs in tsconfig
    • Better type checking out of the box on .js or .svelte files, easy to disable by the end user.

@GrygrFlzr
create-svelte types
9933398 
- Re-added globals.d.ts to JS template
- Fixed globals.d.ts TSDoc notation
- Added vite/client to types in js/tsconfig
- Upped tsconfig target to es2018
- Enable checkJs in js/tsconfig
@dummdidumm dummdidumm merged commit c0ed7a8 into master Mar 14, 2021
@dummdidumm dummdidumm deleted the create-svelte-types branch March 14, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm left review comments

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrygrFlzr @benmccann @dummdidumm