Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monkey-patch formData to enable multipart parsing #5292

Merged
merged 12 commits into from
Jun 29, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jun 28, 2022

This is an alternative to reverting #5117 (#5290). It's ugly, but we can use the multipart form data parsing in node-fetch by monkey-patching the undici Request object's formData method to construct a node-fetch Request with the raw data and call formData on that.

Hideous, but it works. If nodejs/undici#974 is resolved, we can remove this hack.

Marking as draft for now as it should really have a test.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

🦋 Changeset detected

Latest commit: f90cd1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

Hmm. Looks like this might only work on Node 18 for some reason. Maybe the polyfill isn't working on Node 16 as expected?

@Rich-Harris
Copy link
Member Author

Very weird that the allows return value to be a Response test fails in CI. It works locally using the same Node version

@Rich-Harris
Copy link
Member Author

Ok, so it was failing in CI because for some reason I don't fully understand some polyfills were being applied and some weren't, which led to an instanceof check failing. I think the best solution is to always apply all polyfills consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants