-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] don't log warning if root is configured #5330
Conversation
🦋 Changeset detectedLatest commit: 4b3c0dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Can you elaborate? As far as I can tell, setting |
Storybook sets root to the expected directory. SvelteKit doesn't check what the value of the setting is and just prints an error if it's configured at all eventhough there's no actual issue. And SvelteKit doesn't actually set the value so the error message is also incorrect in saying that SvelteKit is taking control of it. |
What is 'the expected directory'? I'm just very unclear on how it could work. It feels like SvelteKit probably should set the value to the project root and/or print an error if it's set to something else |
Storybook sets it to the project root, which is what I meant by expected directory |
Ah. So I think what we should do is error if |
Ok. Updated the PR to do that |
root
is no longer set since #5303. This logs an unnecessary warning when using Storybook