-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only normalise internal URLs #5645
Conversation
🦋 Changeset detectedLatest commit: 5cd877b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
can't reproduce these failures locally. hmm |
oh hang on yes i can. they're in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I have a nagging feeling we should be able to test this in a lighter way, but don't have any immediate suggestions. I think Routify and React Router do some unit tests by mocking the browser, which might work here longer-term
Maybe we could use network mocking https://playwright.dev/docs/test-configuration#network-mocking. I haven't used it so don't know if it's suitable, but possibly worth a try |
fixes #5087, by only normalising URLs we're navigating to once we've established that it's a page within the app
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0