Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] update CWD before running postinstall sync #5771

Merged
merged 3 commits into from
Jul 31, 2022

Conversation

Conduitry
Copy link
Member

Fixes #5769, hopefully. It's really hard to know this sort of thing for sure until we merge and publish.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2022

🦋 Changeset detected

Latest commit: 83121c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

I'm realizing in now that perhaps I shouldn't have done quite so much cleanup here, because it might still be nice to know the full path to the svelte.config.js file we didn't find. I can add that back in if desired.

@Conduitry
Copy link
Member Author

I went ahead and did it. I convinced myself that that was better without anyone else having to do it. The Missing ... - skipping message now has the full path again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use fs with relative paths in svelte.config.js since the postinstall lifecycle hook has a different $PWD
2 participants