-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPTIONS http method Added #6030
Conversation
Fixed sveltejs#5193 Formatted using `pnpm format`
|
Thank you! I'd like to hold off on merging this until we decided what to do with the form proposal, which likely changes what's allowed inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your new test seems to be failing:
@sveltejs/kit:test: 1 failed
@sveltejs/kit:test: [chromium-dev-no-js] › test/server.test.js:52:2 › Endpoints › OPTIONS request ==================
Nice work so far. As this seems to be your first contribution, I'd like to give a small pointer on the use of the PR template: those |
@amunim this PR would need to be rebased and the failing tests would need to be fixed |
I am so confused at this point, I have literally searched the whole project and replaced all 204s with 555, 553, and 554 respectively but am still getting 204 as result in my tests. |
I'll rebase and work on another issue for now... |
Fixed #5193
Formatted using
pnpm format
pnpm test
and lint the project withpnpm lint
andpnpm check
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0