[feat] support for other aliases in package command #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 578b6c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
changed the title
dummdidumm
requested changes
Aug 29, 2022
packages/package/src/utils.js
Outdated
Comment on lines
38
to
45
| for (const [alias, value] of Object.entries(aliases)) { | ||
| content = content.replace(/from\s+('|")([^"';,]+?)\1/g, (match, _, import_path) => | ||
| replace_import_path(match, import_path, alias, value) | ||
| ); | ||
| content = content.replace(/import\s*\(\s*('|")([^"';,]+?)\1\s*\)/g, (match, _, import_path) => | ||
| replace_import_path(match, import_path, alias, value) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is propbably super edge-case-y, but this could theoretically replace import paths multiple times. Could we turn that around and do the for loop inside the replace functions, and check if a replacement was done by checking if output != match?
There was a problem hiding this comment.
You are right, there was that possibility. I moved the loop inside, but I did not understood what you meant by the last part of checking if output != match.
dummdidumm
reviewed
Aug 29, 2022
|
Awesome! Thanks for this 👌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1950
This PR includes support for other aliases besides
$libfor the package command. It reads the alias information fromkitobject insvelte.config.js.I'm not sure this is the correct approach, open to suggestions and improvements.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0