-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse server data if the client load is invalidated #6641
Conversation
🦋 Changeset detectedLatest commit: f0fcc0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think this issue was caused by #6309. So far I couldn't come up with an implementation that would work with both test cases, but @dummdidumm you probably have a better understanding than me of the logic here. |
@@ -759,6 +756,8 @@ export function create_client({ target, base, trailing_slash }) { | |||
throw server_data_node; | |||
} | |||
|
|||
const prev_server_data_node = (!changed?.url && previous?.server) || null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that changed.url
is not the perfect condition, because we will want to reuse the server data of a layout load even if the url changes, but I'm not familiar enough with the code base to determine the correct condition.
Fixes #6459
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0