Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 404 instead of 200 for stale assets with adapter-cloudflare #6879

Merged
merged 4 commits into from
Sep 19, 2022
Merged

fix: return 404 instead of 200 for stale assets with adapter-cloudflare #6879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c8ca87
[fix] return 404 instead of 200 for stale assets
raduab Sep 19, 2022
616a8ed
[chore] code format
raduab Sep 19, 2022
0274556
Merge branch 'master' into raduab/master
Rich-Harris Sep 19, 2022
6682e53
Create healthy-rivers-share.md
Rich-Harris Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-rivers-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sveltejs/adapter-cloudflare": patch
---

[fix] return 404 instead of 200 for missing assets
3 changes: 2 additions & 1 deletion packages/adapter-cloudflare/src/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const worker = {
// static assets
if (pathname.startsWith(prefix)) {
res = await env.ASSETS.fetch(req);
if (!res.ok) return res;

const cache_control = pathname.startsWith(prefix + 'immutable/')
? 'public, immutable, max-age=31536000'
Expand Down Expand Up @@ -65,7 +66,7 @@ const worker = {

// Writes to Cache only if allowed & specified
pragma = res.headers.get('cache-control');
return pragma ? Cache.save(req, res, context) : res;
return pragma && res.ok ? Cache.save(req, res, context) : res;
}
};

Expand Down