Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all excluded files in _routes.json start with / #6952

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

Looks like #6530 broke Cloudflare Pages deployments. I think this should fix it, if I understand correctly. cc @jrf0110 and @jahands for visibility

18:01:33.742 | Found _routes.json in output directory. Uploading.
18:01:33.761 | Validating asset output directory
18:01:34.611 | Deploying your site to Cloudflare's global network...
18:01:39.781 | Parsed 1 valid header rule.
18:01:44.711 | Success: Assets published!
18:01:45.627 | Error: Failed to publish your Function. Got error: Error 8000057: Rules must start with '/' in _routes.json

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: 0200658

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

Not sure why the previous PR didn't trigger a Cloudflare Pages deploy, but this one did and it succeeded, so I'll merge this in order to cut a release

@Rich-Harris Rich-Harris merged commit d0e63d4 into master Sep 21, 2022
@Rich-Harris Rich-Harris deleted the gh-6530-fix branch September 21, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant