Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove builtin modules warning for adapter-node #7031

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 26, 2022

Fix #6931

Set prefersBuiltin: true explicitly for @rollup/plugin-node-resolve to suppress warning (it's true by default).

I also set it for the rollup.config.js used to build adapter-node and adapter-netlify itself for consistency.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

🦋 Changeset detected

Latest commit: 1a08c44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Does this solve the mentioned issue completely? Looking at the log there are other warnings in there, too. I'm not sure they can be silence either way, just making sure don't close it if we can silence the other ones.

@bluwy
Copy link
Member Author

bluwy commented Sep 26, 2022

Oh I didn't realize of the circular dependency errors as the issue title only mentioned the builtin ones. I don't think there's a way to silence the others since it happens within the dependency, unless we switch back to esbuild, so I think we can close the issue with this PR.

@Rich-Harris Rich-Harris merged commit fb96215 into master Sep 26, 2022
@Rich-Harris Rich-Harris deleted the no-builtin-warning branch September 26, 2022 15:23
This was referenced Sep 26, 2022
@CaptainCodeman
Copy link
Contributor

Does this solve the mentioned issue completely?

It solved the "built-in" part, but the circular dependency warnings still occur and the built app fails to run:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'string_decoder' imported from /Users/user/project/packages/public/build/server/chunks/hooks.server-e2ae37d8.js

File contains:

import 'string_decoder/';

Is this maybe still considering something not built-in when it should be or vice-versa?

rollup/plugins#1211

@AndreasHald
Copy link

@CaptainCodeman I'm having the same error from importing string_decoder after updating.

did you figure out a solution?

@CaptainCodeman
Copy link
Contributor

No, I played around with trying to configure rollup via vite but didn't get it working and didn't have time to spend on it.

I'm just pinning things to the esbuild 92 version that works for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"built-in" errors with latest @sveltejs/adapter-node (1.0.0-next.94)
5 participants