[chore] remove unnecessary Request pseudo-header removal #7142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3572 to fix #3566 we started stripping HTTP/2 pseudo-headers from the incoming requests because
node-fetch
'sRequest
implementation couldn't handle them. This may or may not have been possible to revert when we switched toundici
and were only usingnode-fetch
for its multipart formdata handle - but it should certainly be possible now that we're not usingnode-fetch
at all.My understanding is that there's currently something else amiss with Vite's
--https
mode, so I tested this with the Node adapter and a custom entrypoint defining an HTTP/2 server, as described in #3566, and things seemed to work fine.This change does mean that
event.request.headers
will start having these HTTP/2 pseudo-headers present when an HTTP/2 server is being used, but this is probably safe - especially since we're no longer automatically copying incoming request headers into outgoing request headers for server-sidefetch
es.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0