Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove unnecessary Request pseudo-header removal #7142

Merged

Conversation

Conduitry
Copy link
Member

In #3572 to fix #3566 we started stripping HTTP/2 pseudo-headers from the incoming requests because node-fetch's Request implementation couldn't handle them. This may or may not have been possible to revert when we switched to undici and were only using node-fetch for its multipart formdata handle - but it should certainly be possible now that we're not using node-fetch at all.

My understanding is that there's currently something else amiss with Vite's --https mode, so I tested this with the Node adapter and a custom entrypoint defining an HTTP/2 server, as described in #3566, and things seemed to work fine.

This change does mean that event.request.headers will start having these HTTP/2 pseudo-headers present when an HTTP/2 server is being used, but this is probably safe - especially since we're no longer automatically copying incoming request headers into outgoing request headers for server-side fetches.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022

🦋 Changeset detected

Latest commit: 3c398de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 2b59434 into sveltejs:master Oct 4, 2022
@github-actions github-actions bot mentioned this pull request Oct 4, 2022
@Conduitry Conduitry deleted the revert-http2-pseudo-header-removal branch October 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sveltekit via adapter-node can no longer serve over http2
2 participants