Hoist AMP script preload for minor performance improvement 🛥️

[sanjaiyan-dev]

Hoist AMP script preload for minor performance improvement.

Sorry if I made any mistakes :(

[changeset-bot]

🦋 Changeset detected

Latest commit: d96d8bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/amp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[benmccann]

this should use a tab instead of spaces to align with the other lines

[benmccann]

I can't believe this would make any difference. However, if we were going to make this change, wouldn't you also want to move up <script async src="https://cdn.ampproject.org/v0.js"></script>?

[Rich-Harris]

It does seem doubtful that it would make any difference, and it's very surprising to me that the <link> is worth the extra bytes when the <script> immediately follows it, but this does in fact match the current recommended AMP boilerplate, which appears to have changed since this was first created.

[sanjaiyan-dev]

I can't believe this would make any difference. However, if we were going to make this change, wouldn't you also want to move up <script async src="https://cdn.ampproject.org/v0.js"></script>?

Sorry, actually I thought this would have very minor performance improvement because it would have least small improvement than current implementation of adding link:rel=preload just before the script tag.

[sanjaiyan-dev]

It does seem doubtful that it would make any difference, and it's very surprising to me that the <link> is worth the extra bytes when the <script> immediately follows it, but this does in fact match the current recommended AMP boilerplate, which appears to have changed since this was first created.

Ok, I actually made these changes after viewing them on next js implementation of AMP.
They had it like-:

1. link preload
2. Boilerplate CSS
3. Script tag

[Rich-Harris]

thanks!

[sanjaiyan-dev]

thanks!

🤝💪