-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #7355
chore: update dependencies #7355
Conversation
… update env config in turbo
🦋 Changeset detectedLatest commit: 57a0bd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbo.json
Outdated
} | ||
}, | ||
"globalDependencies": [".eslintrc.json", ".prettierrc", "tsconfig.json"] | ||
"$schema": "https://turborepo.org/schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental formatting (now has spaces instead of tabs)? Anything that actually changed in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was done by turbos migration tool and format didn't bother so I kept it that way. The code change is the way env dependencies are declared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just checked what happens and it looks like prettier is never run from the root of the monorepo,
Line 11 in edd815e
"format": "turbo run format", |
i have formatted it manually with pnpm prettier --write turbo.json
to keep the diff smaller here, but we should look into fixing this in a separate PR
no clue why it fails on mac only (4 times so it doesn't seem to be a coincidence). If anyone with a mac is able to reproduce that fail it would help. |
I can reproduce the failure locally. The test is expecting a console warning to appear, and it never does, but only when The thing is the warning is visible in Safari devtools: It looks like a new Playwright bug. Downgrading to 1.25 fixes it, at least locally — 🤞 for a full bank of green lights |
It looks like Rich merged in my change to upgrade to Vite 3.2, but I'm not sure that we should since the Vite 3.2 types are borked so now |
I just merged master to resolve the conflicts. Are you saying we need to downgrade to Vite 3.1.something? Why are the types borked? |
It looks like renovate has not sent PRs for minor updates in a while, so this bumps them accross the board.
There is a test fail that seems to happen due to playwright waitForNavigation behaving differently than before, upon updating from 1.25.0 to 1.27 in vite-plugin-svelte I saw similar problems and worked around them by waiting for more specific events like the vite devserver connection.
Will try to investigate that tomorrow but wanted to see CI results.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0