Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove broken vercel settings image #8607

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 19, 2023

closes #8598

The image is massively too large though. I'm not sure the best way to fix that in a markdown file. Is there some way to specify the size or stop it from overflowing and/or should we shrink the image on the file system? Also, the link checker doesn't know about /static apparently so is erroneously failing to deploy this. Please feel free to take this over

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

⚠️ No Changeset found

Latest commit: bc9d198

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dominikg
Copy link
Member

why in /static, don't we want asset hashing for this?

Seeing this isn't a hi-gloss marketing thing but a tech-doc and the image is auxillary nature, i'm sure we can get away a scaled lossy compressed version. just scaling it to 1024w and saving as 0.5q jpg leaves it with less than 20kb, though i am sure someone else knows an even better way to get that size down more.

Or should we get rid of it altogether which would also eliminate the need to optimize.

@benmccann
Copy link
Member Author

why in /static, don't we want asset hashing for this?

That would be ideal, but I have't tried that in a markdown file before. If it's an easy enough thing to do that'd be great

Or should we get rid of it altogether which would also eliminate the need to optimize.

Yeah, actually looking more closely at this I think that is the better option 😄

@benmccann benmccann changed the title docs: fix inclusion of vercel settings image docs: remove broken vercel settings image Jan 19, 2023
@Rich-Harris Rich-Harris merged commit 6bc699b into master Jan 19, 2023
@Rich-Harris Rich-Harris deleted the vercel-settings-image branch January 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] External images won't load because of CORB
3 participants