Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button:focus CSS styles to template Counter button #957

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Add button:focus CSS styles to template Counter button #957

merged 2 commits into from
Apr 11, 2021

Conversation

bamadesigner
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Anytime a has specific CSS styles for hover state, it should also have those CSS styles for focus state. This helps to highlight interactivity for keyboard users as well as those who use a mouse.

@dummdidumm
Copy link
Member

Thanks for your accessibility PRs! Could add a changeset? Instructions on how to do it are in the main readme; it should be a patch release for create-svelte

@bamadesigner
Copy link
Contributor Author

@dummdidumm Done! Let me know if I did so incorrectly.

@dummdidumm dummdidumm merged commit 59a1e06 into sveltejs:master Apr 11, 2021
@bamadesigner bamadesigner deleted the add/button-focus-css branch March 20, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants