(feat) error-forgiving parser #1177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This was referenced Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more robustness to svelte2tsx with regards to missing properties. This assumes that there's a Svelte parser mode which will continue parsing no matter what and ignore all errors along the way, resulting in a possibly very wrong but somewhat functional AST.
If such a parser mode was implemented in Svelte, it should return the first error it encountered, so that svelte2tsx can fall back to throwing this error if it encounters an error while parsing the broken AST.
I tested this and it resulted in better intellisense in situations where Svelte would bail out on the first parsing error.