-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments get removed from formated Svelte Component #207
Labels
bug
Something isn't working
Comments
I cannot reproduce this given your code snippet. Which version of the plugin are you using? |
Hi, I use Svelte for VS Code v 104.4.1. |
I just discovered something else. It only happens when you have style tags in the document Following removes last comment on format
|
dummdidumm
pushed a commit
to dummdidumm/prettier-plugin-svelte
that referenced
this issue
Feb 17, 2021
When checking if an embed starts after a node, return early if that node is not at the top level of html, because embeds cannot start after it. Fixes sveltejs#207
Merged
dummdidumm
added a commit
that referenced
this issue
Feb 17, 2021
When checking if an embed starts after a node, return early if that node is not at the top level of html, because embeds cannot start after it. Fixes #207
Thanks for fixing that so quickly!
Kind Regards,
Ian Hogers
Email Signature, phone: 0458 452 419, email: [email protected]
…On 2/17/2021 7:45 PM, Simon H wrote:
Closed #207
<#207> via
#208 <#208>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#207 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2QDN4EQILYZ5PGH6JI3R3S7N63XANCNFSM4XVM3NOQ>.
|
I'll write in here once it's released for VS Code |
This was released in the VS Code extension version 104.4.2 |
That's great! Thanks. |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi when I format a svelte component, any comment that is at the end of an element gets removed.
Gets removed:
Doesn't get removed:
Any solutions?
The text was updated successfully, but these errors were encountered: