do not encode entities in attribute values #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehrencrona
commented
Oct 8, 2020
| } else { | ||
| return node.data; | ||
| return getUnencodedText(node); |
There was a problem hiding this comment.
this is the actual bug
ehrencrona
commented
Oct 8, 2020
| @@ -76,7 +76,7 @@ export const inlineElements: TagName[] = [ | |||
| /** | |||
| * HTML attributes that we may safely reformat (trim whitespace, add or remove newlines) | |||
| */ | |||
| export const formattableAttributes = [ | |||
| export const formattableAttributes: string[] = [ | |||
There was a problem hiding this comment.
this is unrelated but fixes warning
dummdidumm
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29 (comment) :
<i data-icon="">icon</i>was turned into<i data-icon="">icon</i>I introduced a new function to explain what
node.raw || node.datawas doing; I hadn't understood it.