Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) support svelteSingleAttributePerLine #312

Closed
wants to merge 2 commits into from
Closed

(feat) support svelteSingleAttributePerLine #312

wants to merge 2 commits into from

Conversation

david-ding
Copy link
Contributor

This PR addresses #305 by adding a new option svelteSingleAttributePerLine, mirroring behaviour of singleAttributePerLine from prettier.

@david-ding
Copy link
Contributor Author

david-ding commented Oct 4, 2022

@dummdidumm please have a look and let me know if this looks ok. also while working on this I've noticed that we don't seem to respect bracketSameLine option for svelte:options, svelte:body elements as well as the top level parts (script, style etc), not sure if I should address these too in this PR? thanks

edit added another commit to address the above-mentioned issue, after second thought this issue could be more obvious with svelteSingleAttributePerLine: true now where it would affect elements with just 2 attributes, so guess it makes sense to address it here. anyways would love to hear your opinions on this.

@david-ding david-ding closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant