destructure await #4548
Merged
destructure await #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/destructure-await
branch
from
c1d394a to
96156d0
Compare
tanhauhau
force-pushed
the
tanhauhau/destructure-await
branch
from
81b7845 to
e546487
Compare
|
Is there some DRYing that we can do between each block destructuring and await block destructuring now? We can do that in a separate issue/PR if so. |
|
oh.. i didn't know there's another util for each destructuring, https://github.com/sveltejs/svelte/blob/master/src/compiler/parse/read/context.ts#L46 interestingly, it doesn't support default values in destructuring: {#each list as { a = 2 }} // error: assignment pattern are not supported
{#each list as [ a = 2 ]} // error: assignment pattern are not supporteddo you think we should support that when DRYing them out? |
xla
added a commit
to radicle-dev/prettier-plugin-svelte
that referenced
this pull request
Mar 22, 2020
Svelte 3.20.0 introduced support for await destructing, see svetlejs/svelte#1851 and sveltejs/svelte#4548. This change supports this syntax and keep this plugin functional with the newest svelte version
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1851