Skip to content

Commit

Permalink
chore(node): drop support for 14 and 16 (#744)
Browse files Browse the repository at this point in the history
  • Loading branch information
dominikg authored Sep 15, 2023
1 parent bd5d43e commit d5b952f
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 22 deletions.
6 changes: 6 additions & 0 deletions .changeset/big-items-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@sveltejs/vite-plugin-svelte-inspector': major
'@sveltejs/vite-plugin-svelte': major
---

breaking: update minimum supported node version to node18
20 changes: 2 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
matrix:
# pseudo-matrix for convenience, NEVER use more than a single combination
node: [16]
node: [18]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -73,16 +73,10 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [16]
node: [18]
os: [ubuntu-latest, macos-latest, windows-latest]
svelte: [4]
include:
- node: 14
os: ubuntu-latest
svelte: 3
- node: 18
os: ubuntu-latest
svelte: 4
- node: 20
os: ubuntu-latest
svelte: 4
Expand All @@ -92,17 +86,11 @@ jobs:
with:
node-version: ${{ matrix.node }}
- name: install pnpm
if: matrix.node != 14
shell: bash
run: |
PNPM_VER=$(jq -r '.packageManager | if .[0:5] == "pnpm@" then .[5:] else "packageManager in package.json does not start with pnpm@\n" | halt_error(1) end' package.json)
echo installing pnpm version $PNPM_VER
npm i -g pnpm@$PNPM_VER
- name: install legacy pnpm for node14
if: matrix.node == 14
run: |
npm i -g pnpm@^7.33.0
tmppkg="$(jq '.engines.pnpm = "^7.33.0"' package.json)" && echo -E "${tmppkg}" > package.json && tmppkg=""
- name: use svelte 3
if: matrix.svelte == 3
run: |
Expand All @@ -113,11 +101,7 @@ jobs:
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- name: install
if: matrix.node != 14 && matrix.svelte != 3
run: pnpm install --frozen-lockfile --prefer-offline --ignore-scripts
- name: install for node14 or svelte3
if: matrix.node == 14 || matrix.svelte == 3
run: pnpm install --no-frozen-lockfile --prefer-offline --ignore-scripts
- name: install playwright chromium
run: pnpm playwright install chromium
- name: run tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
# pseudo-matrix for convenience, NEVER use more than a single combination
node: [16]
node: [18]
os: [ubuntu-latest]
steps:
- name: checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"packageManager": "[email protected]",
"engines": {
"pnpm": "^8.6.3",
"node": "^14.18.0 || >= 16"
"node": "^18.0.0 || >=20"
},
"pnpm": {
"overrides": {
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-svelte-inspector/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"check:types": "tsc --noEmit"
},
"engines": {
"node": "^14.18.0 || >= 16"
"node": "^18.0.0 || >=20"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"check:types": "tsc --noEmit"
},
"engines": {
"node": "^14.18.0 || >= 16"
"node": "^18.0.0 || >=20"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit d5b952f

Please sign in to comment.