Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune](deps): Bump optuna from 2.3.0 to 2.5.0 in /python/requirements #5

Closed
wants to merge 1 commit into from
Closed

[tune](deps): Bump optuna from 2.3.0 to 2.5.0 in /python/requirements #5

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Feb 6, 2021

Bumps optuna from 2.3.0 to 2.5.0.

Release notes

Sourced from optuna's releases.

v2.5.0

This is the release note of v2.5.0.

Highlights

Ask-and-Tell

The ask-and-tell interface is a new complement to Study.optimize. It allows users to construct Trial instances without the need of an objective function callback, giving more flexibility in how to define search spaces, ask for suggested hyperparameters and how to evaluate objective functions. The interface is made out of two methods, Study.ask and Study.tell.

  • Study.ask returns a new Trial object.
  • Study.tell takes either a Trial object or a trial number along with the result of that trial, i.e. a value and/or the state, and saves it. Since Study.tell accepts a trial number, a trial object can be disposed after parameters have been suggested. This allows objective function evaluations on a different thread or process.
import optuna
from optuna.trial import TrialState
study = optuna.create_study()
Use a Python for-loop to iteratively optimize the study.
for _ in range(100):
trial = study.ask()  # trial is a Trial and not a FrozenTrial.
# Objective function, in this case not as a function but at global scope.
x = trial.suggest_float("x", -1, 1)
y = x ** 2
study.tell(trial, y)
Or, tell by trial number. This is equivalent to study.tell(trial, y).
study.tell(trial.number, y)
Or, prune if the trial seems unpromising.
study.tell(trial, state=TrialState.PRUNED)

assert len(study.trials) == 100

Heartbeat

Now, Optuna supports monitoring trial heartbeats with RDB storages. For example, if a process running a trial is killed by a scheduler in a cluster environment, Optuna will automatically change the state of the trial that was running on that process to TrialState.FAIL from TrialState.RUNNING.

# Consider running this script on several processes. 
import optuna
def objective(trial):
(Very time-consuming computation)
Recording heartbeats every 60 seconds.
Other processes' trials where more than 120 seconds have passed
</tr></table>

... (truncated)

Commits
  • f3b868c Merge pull request #2282 from HideakiImamura/bump-up-v2.5.0
  • 2874c76 Bump up version to v2.5.0
  • 1cd0830 Merge pull request #2257 from keisuke-umezawa/fix/add-init-files
  • 59704fb Merge pull request #2261 from not522/add_trials
  • 0786594 Return None in add_trials
  • 6568ef9 Merge pull request #2190 from HideakiImamura/feature/heartbeat-with-threading
  • 7d0aa70 Merge pull request #2260 from toshihikoyanase/followup-2259-pin-mypy-version-...
  • 28356d5 Add init files
  • 0db3a46 Merge pull request #2205 from toshihikoyanase/handle-trials-without-constraints
  • 6670c3f Merge branch 'master' into feature/heartbeat-with-threading
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 6, 2021
@dependabot dependabot bot mentioned this pull request Feb 6, 2021
Closed
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 9, 2021

Superseded by #7.

@dependabot dependabot bot closed this Mar 9, 2021
@dependabot dependabot bot deleted the dependabot/pip/python/requirements/optuna-2.5.0 branch March 9, 2021 10:36
sven1977 pushed a commit that referenced this pull request Jul 28, 2022
@kfstorm
[Core] No RAY_LOG in the constructor of DelayManager (ray-project#26958)
34d0233 
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
sven1977 pushed a commit that referenced this pull request Mar 8, 2023
@jianoaix
[Datasets] Streaming executor fixes #5 (ray-project#32951)
303ac3b
sven1977 added a commit that referenced this pull request Jan 19, 2024
@sven1977
[RLlib] New ConnectorV3 API #5: PPO runs in single-agent mode in this…
e03dd6e 
… API stack. (ray-project#42272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants