Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for project/repository publication #59

Closed
svengreb opened this issue Nov 13, 2020 · 0 comments · Fixed by #60
Closed

Prepare for project/repository publication #59

svengreb opened this issue Nov 13, 2020 · 0 comments · Fixed by #60
Labels
context-documentation scope-compatibility target-base type-task
Milestone
0.8.0

Comments

@svengreb
Copy link
Owner

Before switching the GitHub repository visibility to "public" a few adjustments need to be made.
This is basically a revert of #22, taking the changes from #23 into account, so that SVG images like the repository hero are using the URLs for public repositories again instead of the ones that allow to resolve the files in private repositories.

-https://github.com/svengreb/tmpl/blob/main/assets/images/repository-hero.svg?raw=true
+https://raw.githubusercontent.com/svengreb/tmpl/main/assets/images/repository-hero.svg?sanitize=true
@svengreb svengreb added this to the Next milestone Nov 13, 2020
@svengreb svengreb self-assigned this Nov 13, 2020
svengreb added a commit that referenced this issue Nov 14, 2020
@svengreb
Prepare for project/repository publication
d0043da 
To switch the GitHub repository visibility [1] to "public" a few
adjustments had to be made.
This includes the referenced SVG images in documentations, like e.g.
the repository hero, to use the URLs for public repositories instead of
the ones that allow to resolve the files in private repositories.

[1]: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/setting-repository-visibility

GH-59
@svengreb svengreb mentioned this issue Nov 14, 2020
Merged
svengreb added a commit that referenced this issue Nov 14, 2020
@svengreb
Prepare for project/repository publication (#60)
5023833 
To switch the GitHub repository visibility [1] to "public" a few
adjustments had to be made.
This includes the referenced SVG images in documentations, like e.g.
the repository hero, to use the URLs for public repositories instead of
the ones that allow to resolve the files in private repositories.

[1]: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/setting-repository-visibility

Closes GH-59
@svengreb svengreb removed their assignment Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-documentation scope-compatibility target-base type-task
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Prepare for project/repository publication svengreb/tmpl
1 participant
@svengreb