Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Bump cobra to 1.3.0, replace completion command #47

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

svix-frank
Copy link
Contributor

@svix-frank svix-frank commented Jul 11, 2021

The new version of cobra autogenerates a completion command which has the same interface as our custom one, so we can update and drop our command (fewer things to support)! 🎉

@svix-frank svix-frank changed the title Bump cobra to 1.6.1, replace completion command Bump cobra to 1.8.1, replace completion command Jul 11, 2021
@svix-frank svix-frank requested review from tasn and a team July 11, 2021 03:40
svix-liam
svix-liam previously approved these changes Jul 11, 2021
@svix-frank svix-frank changed the title Bump cobra to 1.8.1, replace completion command Bump cobra to 1.2.1, replace completion command Jul 11, 2021
@tasn
Copy link
Member

tasn commented Jul 11, 2021

🎉

@fcjr
Copy link
Contributor

fcjr commented Jul 12, 2021

This might be minor but I realized the short desc for the generated command starts with a lowercase letter which looks pretty unprofessional given the rest are capitalized. (The help desc is autogenerated with an uppercase so we can't just change to all lowercase). I made a PR to upstream, gonna hold off on merging this until its released. spf13/cobra#1455

@svix-frank
Copy link
Contributor Author

This might be minor but I realized the short desc for the generated command starts with a lowercase letter which looks pretty unprofessional given the rest are capitalized. (The help desc is autogenerated with an uppercase so we can't just change to all lowercase). I made a PR to upstream, gonna hold off on merging this until its released. spf13/cobra#1455

My cobra patch finally got merged, just waiting for them to make another release.

@tasn
Copy link
Member

tasn commented Dec 11, 2021

🎉

@svix-frank svix-frank changed the title Bump cobra to 1.2.1, replace completion command Bump cobra to 1.3.0, replace completion command Dec 14, 2021
@svix-frank svix-frank requested a review from svix-liam December 14, 2021 21:43
@svix-frank svix-frank merged commit f08d512 into main Dec 15, 2021
@svix-frank svix-frank deleted the frank/bump_cobra branch December 15, 2021 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants