V2: Update Makefile #1560
Merged
V2: Update Makefile #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove repeat net/http
* Add template action delimiter cli flag * Add delims to generator config and template Also adds tests using the "quote" test as a base. This has to have a custom Instance name or it will clash with the "quotes" one and panic since it will have registered two "swagger" instances in the package test. * Add testdata for custom delim flags Based on the "quote" testdata. * Add delims to the spec, with tests. Make sure we don't add delims if they are empty. This shouldn't be possible, but might as well be safe. * Go mod tidy and sum update * Make the CLI experience a bit cleaner * Revert go.mod and sum * Update readme
Signed-off-by: sdghchj <[email protected]>
Nerzal
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #1560 +/- ##
==========================================
+ Coverage 77.67% 79.52% +1.85%
==========================================
Files 21 21
Lines 5528 5549 +21
==========================================
+ Hits 4294 4413 +119
+ Misses 1048 962 -86
+ Partials 186 174 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ubogdan
approved these changes
Apr 19, 2023
|
@Nerzal as a member, you can create a branch in swaggo/swag repository. You don't need to use a forked repo any more. |
|
Yeah, that is also definitely going to prevent problems with pushing tags to the wrong repo. I'll use this from now on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Merged master branch into v2 branch.
Also integrated the new delimiter feature into the v3 generator